(feature): docker health checks#12124
Draft
getpwnam wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
| healthcheck: | ||
| test: | ||
| [ | ||
| 'CMD-SHELL', |
Member
There was a problem hiding this comment.
I think we should expose an invoke command to determine the health of the background worker process - which could encapsulate the code her potentially
Member
|
@getpwnam thanks for submitting this, overall it looks pretty reasonable. What are your thoughts about exposing an internal function (e.g. invoke task) for background worker health check? This makes it a bit more general purpose I think. Also, do you have any tracing or metrics over the 10 day period you have been running this? In particular what load does a 20s interval impose on the setup? |
Member
Requested Improvements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add health checks for each container in
docker-compose.ymland updated dependencies to require healthy state in each case.pg_isreadysucceedsredis-cli pingsucceeds/api/system/health/returns HTTP 200is_worker_running()returns True/api/system/health/withHost: ${INVENTREE_SITE_URL}returns HTTP 200Tested on my v1.3.3 instance for around 10 days with no problems to report.
Would appreciate some extra testing/validation from a Docker expert.
Refs: #12122
Refs: #12123