Skip to content

[tooling] Publish monitoring repo as PyPI package#1473

Open
the-glu wants to merge 1 commit into
interuss:mainfrom
Orbitalize:fix_1398
Open

[tooling] Publish monitoring repo as PyPI package#1473
the-glu wants to merge 1 commit into
interuss:mainfrom
Orbitalize:fix_1398

Conversation

@the-glu
Copy link
Copy Markdown
Contributor

@the-glu the-glu commented May 20, 2026

Fix #1398 by publishing the monitoring repo as pypi package.

A few note:

  • I didn't tested github workflow as they need a release and a token
  • A token is needed and need to be set on the repository
  • I had to loose constraint version on python version since requiering an explicit one is 'too tight'.
  • I targeted specifc monitoring part to be included. Final version look like that:
image

Tested in a dedicated venv and seems to be working:

uv add /tmp/monitoring-0.28.1.dev0+ge1602f144.d20260520-py3-none-any.whl
uv run python
Python 3.13.11 (main, Jan 28 2026, 00:01:45) [Clang 21.1.4 ] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from monitoring.monitorlib.geo import Altitude
>>> 
>>> Altitude
<class 'monitoring.monitorlib.geo.Altitude'>

@the-glu the-glu force-pushed the fix_1398 branch 2 times, most recently from 9b91610 to 0e8853b Compare May 20, 2026 15:49
Copy link
Copy Markdown
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm super excited about this as I've thought it would be useful for a while! I'll add the tokens; just one small question.

Comment thread monitoring/Dockerfile Outdated
ENV UV_LINK_MODE=copy
ENV UV_PROJECT_ENVIRONMENT=/venv/
ENV VIRTUAL_ENV=/venv/
ENV SETUPTOOLS_SCM_PRETEND_VERSION_FOR_MONITORING=0.0.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: The build system used with version is not happy inside the docker build, as it doesn't have the .git folder to dectect the version.

I switched to use the $version arg however.

Copy link
Copy Markdown
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I was too hasty in my approval; the hygiene check seems to be a true failure and not a transient false positive.

@the-glu
Copy link
Copy Markdown
Contributor Author

the-glu commented May 21, 2026

Apparently I was too hasty in my approval; the hygiene check seems to be a true failure and not a transient false positive.

Yes I forgot to put it in draft, sorry. It should be fixed now.

I had to add some fixes as it's now a package (to prevent it from trying to reinstall monitoring), but this add some warning in some cases (warning: --no-sync has no effect when used outside of a project). I think that could be left for future work as it's just a warning.

@the-glu the-glu requested a review from BenjaminPelletier May 21, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish monitoring repo content as PyPI package

2 participants