[tooling] Publish monitoring repo as PyPI package#1473
Conversation
9b91610 to
0e8853b
Compare
BenjaminPelletier
left a comment
There was a problem hiding this comment.
I'm super excited about this as I've thought it would be useful for a while! I'll add the tokens; just one small question.
| ENV UV_LINK_MODE=copy | ||
| ENV UV_PROJECT_ENVIRONMENT=/venv/ | ||
| ENV VIRTUAL_ENV=/venv/ | ||
| ENV SETUPTOOLS_SCM_PRETEND_VERSION_FOR_MONITORING=0.0.0 |
There was a problem hiding this comment.
Yes: The build system used with version is not happy inside the docker build, as it doesn't have the .git folder to dectect the version.
I switched to use the $version arg however.
BenjaminPelletier
left a comment
There was a problem hiding this comment.
Apparently I was too hasty in my approval; the hygiene check seems to be a true failure and not a transient false positive.
Yes I forgot to put it in draft, sorry. It should be fixed now. I had to add some fixes as it's now a package (to prevent it from trying to reinstall monitoring), but this add some warning in some cases ( |
Fix #1398 by publishing the monitoring repo as pypi package.
A few note:
Tested in a dedicated venv and seems to be working: