Conversation
Replace Access-Control-Allow-Origin: * with HTTPS origin matching so bgc/v1 no longer reflects arbitrary or null Origins or send credentials. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG3-217. JIRA: https://imh-internal.atlassian.net/browse/ENG3-217
Central Connect no longer sends
Access-Control-Allow-Origin: *on REST or HEAD discovery. In-scopebgc/v1and REST index responses emit CORS only for an exact HTTPS Central portal allowlist (config/branding URLs,https://v2.central.inmotionhosting.com, and thecentral_connect_allowed_cors_originsfilter). Arbitrary,null,http, and IP-literal Origins get no ACAO.Access-Control-Allow-Credentialsis never sent.WordPress core CORS is left in place for other namespaces; in-scope routes scrub those headers at
PHP_INT_MAXbefore applying this policy.Test plan
php tests/run.phpfrom the repo root (28 cases)bgc/v1still returns ACAO for that origin and no credentialsbgc/v1