Skip to content

rename host references in BlockWatcher to rollup#141

Closed
Evalir wants to merge 1 commit intomainfrom
evalir/rename-host-references-in-blockwatcher-to-rollup
Closed

rename host references in BlockWatcher to rollup#141
Evalir wants to merge 1 commit intomainfrom
evalir/rename-host-references-in-blockwatcher-to-rollup

Conversation

@Evalir
Copy link
Copy Markdown
Member

@Evalir Evalir commented Apr 30, 2026

Summary

Renames "host" terminology to "rollup" in BlockWatcher to accurately reflect what it watches. The watcher subscribes to blocks on the rollup chain, not the host chain, so the prior naming was misleading.

Changes

  • Module/struct doc comments updated from "Host chain" → "Rollup chain"
  • host_provider field and constructor parameters renamed to rollup_provider
  • Log messages ("subscribed to host chain blocks", "updated host block number") updated to say "rollup"

Breaking change

BlockWatcher::new and BlockWatcher::with_current_block parameter names changed. Callers using positional args are unaffected; any callers passing the argument by name will need to update.

Test plan

  • cargo clippy -p init4-bin-base --all-features --all-targets passes

Copy link
Copy Markdown
Member Author

Evalir commented Apr 30, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Evalir Evalir marked this pull request as ready for review April 30, 2026 19:04
@Evalir Evalir requested review from Fraser999 and prestwich April 30, 2026 19:05
Copy link
Copy Markdown
Contributor

@Fraser999 Fraser999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just remove all mention of "host" or "rollup" since the block watcher could be used to track either chain?

@Evalir
Copy link
Copy Markdown
Member Author

Evalir commented May 4, 2026

i'm amenable to that, it's probably the best choice

@Evalir Evalir closed this May 4, 2026
@Evalir Evalir deleted the evalir/rename-host-references-in-blockwatcher-to-rollup branch May 4, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants