[IMP] hr_holidays_ux: prevent auto-approval in batch allocations#63
Closed
mav-adhoc wants to merge 1 commit into
Closed
[IMP] hr_holidays_ux: prevent auto-approval in batch allocations#63mav-adhoc wants to merge 1 commit into
mav-adhoc wants to merge 1 commit into
Conversation
Override action_generate_allocations on the multi-allocation wizard so allocations created via "New Group Allocation" stay in 'confirm' (To Approve) instead of being auto-approved, regardless of the leave type's validation setting. no_validation types still auto-approve via the create() hook. Add action_reset_to_confirm on hr.leave.allocation to revert validated allocations back to 'confirm'. Blocked when leaves_taken > 0; permission checks delegated to _check_approval_update (officer role required). Add server action bound to the allocation list view to expose action_reset_to_confirm from the Actions menu.
Contributor
|
|
Contributor
|
@roboadhoc r+ nobump |
roboadhoc
pushed a commit
that referenced
this pull request
Jun 25, 2026
Override action_generate_allocations on the multi-allocation wizard so allocations created via "New Group Allocation" stay in 'confirm' (To Approve) instead of being auto-approved, regardless of the leave type's validation setting. no_validation types still auto-approve via the create() hook. Add action_reset_to_confirm on hr.leave.allocation to revert validated allocations back to 'confirm'. Blocked when leaves_taken > 0; permission checks delegated to _check_approval_update (officer role required). Add server action bound to the allocation list view to expose action_reset_to_confirm from the Actions menu. closes #63 Signed-off-by: Juan Carreras <jc@adhoc.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action_generate_allocationsonhr.leave.allocation.generate.multi.wizardso allocations created via "New Group Allocation" stay inconfirm(To Approve) instead of being auto-approved. Types withno_validationstill auto-approve via thecreate()hook.action_reset_to_confirmonhr.leave.allocationto revert validated allocations back toconfirm. RaisesUserErrorifleaves_taken > 0; permission checks delegated to_check_approval_update.action_reset_to_confirm.Test plan
leaves_taken > 0→ UserError raised.UserErrorfrom_check_approval_update.Related task: https://www.adhoc.inc/odoo/knowledge/180/902/tasks/64815