Skip to content

The fix from PR #537 was lost from master #543

Description

@gl0balw0rk

Issue Type

  • Bug Report

Faraday version

Faraday v5.23.0 (Docker image faradaysec/faraday:latest, published 2026-07-23)

Component Name

WebGui / Docker deployment

Steps to reproduce

  1. Fresh installation following the official guide:

    curl -O https://raw.githubusercontent.com/infobyte/faraday/master/docker-compose.yaml
    docker compose up -d
  2. Wait until all containers report healthy.

  3. Open http://localhost:5985/

Expected results

The web UI loads (HTTP 200) on first access.

Debugging tracebacks (current results)

HTTP 500 on GET /. From docker compose logs faraday-server:

TypeError: create_app.<locals>.index() got an unexpected keyword argument 'text'
  File "/src/.venv/lib/python3.11/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)

Root cause: In faraday/server/app.py (current master, commit b6a06c56d), the routes declare a text parameter but the view signature doesn't accept it:

@app.route('/', defaults={'text': ''})
@app.route('/<path:text>')
def index(ex):   # <- should be def index(ex=None, text=None):

This bug was already fixed by PR #537 (merged 2026-06-23 by @nahwar, merge commit af423823c), which resolved #536. However, the merge commit is no longer reachable from master — it appears a later regeneration of master from the internal white/dev branch silently dropped it:

$ git merge-base --is-ancestor af423823c origin/master && echo yes || echo no
no

$ git log origin/master --oneline | grep -c "Merge pull request #537"
0

$ grep -n "def index" faraday/server/app.py   # at origin/master HEAD
447:    def index(ex):

Because GitHub keeps showing PR #537 as "MERGED" (a historical PR event, not a property of the current branch), the regression went unnoticed. As a result, every published Docker image since at least 5.18.0 ships the bug, and #541 (same traceback on v5.22.0) was closed with a workaround that no longer works (rebuilding from master does not help — master itself is broken).

Proposed fix: re-apply the one-line change from PR #537 (def index(ex=None, text=None)) to the internal white/dev branch so it survives the next sync to master, republish the Docker image, and consider reopening #536 until the fix reaches a released artifact.

Verified locally: applying this single-line patch and rebuilding the image (docker compose build faraday-server) makes GET / return HTTP 200 and the UI fully loads.

Screenshots

N/A — traceback above is from the server logs.

Environment information

Configuration files

Default docker-compose.yaml from master, unmodified.

Reports/Extra data

N/A

OS

Arch Linux

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions