Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Adapt mount and quota preparation from Tianyu Zhou\u0027s 4ff87a3 while preserving the current filestore validation and parent mount namespace handling. Persist the per-sandbox checkpoint opt-in and require managed artifacts on restore. Co-authored-by: Tianyu Zhou <zhoutianyu1995@gmail.com>
614446b to
f5c57b1
Compare
|
Closing this older managed-upper Draft as superseded by the integrated, now-merged #98 ( The current implementation retains checkpoint-managed file-backed private upper mounts with quota/restore validation, reuse of immutable OCI metadata through the existing ROFS/Bolt store, and checkpoint stage timing. #98 additionally provides the platform-owned managed runtime profile and associated transport/recovery fixes. The current HK1019 image uses that exact Sandboxd source. This earlier patch no longer needs an independent merge; remaining platform integration is tracked in inclusionAI/AKernel#148. |
Add opt-in
extra_config.fileBackedTmpfsMountsso Docker/containerd private writable upper files use sandbox-owned anonymous filestores instead of being copied into checkpoint RAM pages. Immutable lower roots continue through the existing shared ROFS provider. The implementation adapts Tianyu Zhou's managed-upper work.Review baseline
Rebased on current
inclusionAI/sandboxd:mainat 91d9d05 (Sandboxd's maintained target branch; the AKernel consumer targets develop). Current head: f5c57b1. Preserve the new upstream gVisor/Firecracker release pins, installers and CI without reverting them.Changes to review
The five feature/documentation commits are retained as separate review units. Primary files:
pkg/runtime/runsc/filestore_mounts.go,client.go/handler.go,pkg/imagemanager/oci/immutable_images.go, andinternal/server/checkpoint.go. The public contract is indoc/checkpoint-restore.md.Example:
{"fileBackedTmpfsMounts":[{"target":"/var/lib/akernel-image-snapshots","sizeMB":2048}]}Consumer and merge boundary
AKernel #127 supplies image preparation, Docker/Compose and original-process handles using the current AKernel develop SDK. The AKernel consumer must pin the merged Sandboxd revision and qualify a normal image build before delivering this profile. AKernel #126 exposes explicit Helm reflink configuration.
The existing complete runtime bundle must support anonymous filestores/FICLONE. On Linux 5.10, live and checkpoint backing must use the same mount object. Reflink shares filesystem data; RAM pages are still captured normally. No production deployment, Coordinator, runtime pin, durability policy or scoring threshold is changed here.
Validation
make check-fmt,make vetandmake testpassed, including managed target/quota checks, persisted opt-in, missing artifacts, immutable metadata reuse/fallback and reference rollback.Keep this Draft pending review and fresh isolated consumer/bundle qualification.