Repository navigation
Conversation
Pin the complete amd64 and arm64 archives promoted unchanged from the qualified candidate. Busy Loader state queries use the existing liveness fallback instead of blocking node-wide inventory during kernel restore. Record the temporary fork provenance and preserve the runtime availability and checkpoint timeout contracts. Both published archives match the gated candidate SHA-512 digests. Signed-off-by: 月可 <hukeyang.hky@antgroup.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Signed-off-by: 月可 <hukeyang.hky@antgroup.com> (cherry picked from commit e92a7880766dc3fca44c983d05f3d3389ab1f57f)
Signed-off-by: 月可 <hukeyang.hky@antgroup.com>
Treat omitted and zero restore_concurrency as unlimited. Only positive values enable the per-process Start RPC semaphore, while health waits, request deadlines and cancellation keep their existing semantics. Add TOML-backed regression coverage that holds more than 16 restores for both disabled configurations, and update the checkpoint contract. Signed-off-by: 月可 <hukeyang.hky@antgroup.com>
|
Closing this earlier Draft because its Sandboxd-side behavior is included in the integrated, now-merged #98 ( The retained implementation includes inventory recovery within the caller's deadline, restore Start admission disabled by default/0 and enabled only by an explicit positive limit, and volatile staging-overlay handling with the older-kernel fallback. The older August runtime pin in this PR is superseded by the current complete |
Concurrent restores can block gVisor state queries and put pressure on shared storage during filesystem preparation, metadata synchronization and memory loading. A temporary inventory failure can then reject accepted restores. This PR keeps runtime inventory responsive, waits for real inventory recovery within the request deadline, and provides an opt-in concurrency limit for runsc restore Start RPCs.
release-20260817.0-akernel.6, including the state-query fix in fix(runsc): backport upstream lock-free and bounded inventory akernel-dev/gvisor#12. Runsc, the shim and all four helpers use the same verified architecture-specific archive. This PR does not rebuild the bundle.volatile. Guest writable filestores and checkpoint output synchronization retain their existing semantics.plugin.runtime.runsc.restore_concurrency: omitted or0disables the concurrency limit. Only an explicitly configured positive value enables it; valid positive values are 1–1024. When enabled, a permit spans the complete restore Start RPC, including filesystem preparation, before sandbox ID or resource reservation. Cold starts, cleanup and other runtimes keep their existing paths.No runtime polling timeout or Relay TCP connection timeout is increased. Coordinator changes are outside this PR.
Validation of current revision
bf44cf21cb79877d349455561a869e2016ab8ec0:restore_concurrency = 0. Before this revision both configurations fail at request 17; afterward both pass.make check-fmt,make vetandmake testpass; the full unit run reports 41 tested packages.go test -race ./internal/server ./pkg/sandbox -run 'TestRestoreAdmission|TestWaitRuntimeHealth' -count=1passes.Historical qualification applies to the preceding candidate, not the new disabled default:
35f1361and HK companionda0ec5dused an implicit concurrency limit of 16. Their earlier PR checks, runtime qualification and cluster experiments do not establish performance or cluster correctness of the current unlimited default.04c9419was not deployed and its admission issue is not claimed fixed here.No production image, configuration, deployment or cluster workload was changed for the current revision. The previously deployed binary retains its old default behavior until a separately reviewed release is deployed. No new cluster qualification is claimed for unlimited admission.