feat(WEB-1059): add v2 iconic_taxa_counts endpoint

[caseyhofford]

Adds a category to the iconic_taxa_counts endpoint response for unknown taxa. This is identified by a result in the results list where taxon is null.

results [ 
    {
        "count": 2198,
        "taxon": null
    },
    ...
]

inaturalist/inaturalistjs#110 adds better handling of the Unknown Taxon in inaturalistjs.

[jwidness]

While you're working on the iconic_taxa_counts code, could you fix the bug that limits the result set for both this and iconic_taxa_species_counts to only 10, despite the fact that there are 14 iconic taxa?

Both of these terms aggregations use the ES default of 10 items, they need an explicit size of at least 14 to accommodate all the iconic taxa:

iNaturalistAPI/lib/controllers/v1/observations_controller.js

Line 972 in f06ee6e

terms: { field: "taxon.iconic_taxon_id" }

iNaturalistAPI/lib/controllers/v1/observations_controller.js

Line 1003 in f06ee6e

terms: { field: "taxon.iconic_taxon_id" },

Thanks!

[caseyhofford]

While you're working on the iconic_taxa_counts code, could you fix the bug that limits the result set for both this and iconic_taxa_species_counts to only 10, despite the fact that there are 14 iconic taxa?

Both of these terms aggregations use the ES default of 10 items, they need an explicit size of at least 14 to accommodate all the iconic taxa:

iNaturalistAPI/lib/controllers/v1/observations_controller.js

Line 972 in f06ee6e

terms: { field: "taxon.iconic_taxon_id" }

iNaturalistAPI/lib/controllers/v1/observations_controller.js

Line 1003 in f06ee6e

terms: { field: "taxon.iconic_taxon_id" },

Thanks!

Yes @jwidness, thanks for the suggestion! That should be handled here by setting size: 100 (https://github.com/inaturalist/iNaturalistAPI/pull/645/changes#diff-5d993c2b6e61f365a5f6758cb3612f39b26d3ee92c813066feb3bae301d23943R972), I'll add a spec to confirm this works.

[jwidness]

Great! I obviously should have looked closer at the changed files 😅

[jwidness]

Also, thanks for adding this to v2 -- I was told only a couple months ago that it wasn't on the agenda, so it's a nice surprise.

[caseyhofford]

@jwidness no worries! Maybe I should set it to exactly 14 so it's clearer why this is a non default value, since it is not obvious. This change became necessary for the My Observations page in the react native app which got this prioritized, I'm glad to hear it's helpful for you too!

[pleary]

Looks great to me. Thanks!