Skip to content

transpile: Compute and store override_tys ahead of time#1679

Open
Rua wants to merge 5 commits into
immunant:masterfrom
Rua:override_ty
Open

transpile: Compute and store override_tys ahead of time#1679
Rua wants to merge 5 commits into
immunant:masterfrom
Rua:override_ty

Conversation

@Rua
Copy link
Copy Markdown
Contributor

@Rua Rua commented Mar 20, 2026

Before proceeding to remove override_ty, I added a temporary assert to compare the value passed to convert_expr with the value being generated by the new method. The assert eventually passed in the full CI suite, which likely means they match perfectly.

There was a comment left here concerning this issue:

// TODO We'd like to get rid of this cast eventually (see #1321).

I don't think the cast can be removed, though. In the snapshot test, the LITERAL_FLOAT and NESTED_FLOAT macros switched type from double to float, which removed some casts to float, but caused new casts to double to be added elsewhere.

@Rua Rua force-pushed the override_ty branch 5 times, most recently from 4154acf to 59262d2 Compare March 20, 2026 19:06
@Rua Rua force-pushed the override_ty branch 7 times, most recently from a328a7a to ad084f6 Compare March 21, 2026 13:41
@Rua Rua marked this pull request as ready for review March 21, 2026 13:42
@Rua Rua force-pushed the override_ty branch 6 times, most recently from 7d2728f to a5bf63e Compare March 24, 2026 11:32
@Rua Rua force-pushed the override_ty branch 5 times, most recently from 9d229f2 to dd4f7ce Compare April 24, 2026 13:34
@Rua Rua marked this pull request as draft April 24, 2026 13:47
@Rua Rua force-pushed the override_ty branch 3 times, most recently from 712c418 to a1aab1c Compare April 24, 2026 16:16
@Rua Rua force-pushed the override_ty branch 3 times, most recently from 4a13fb2 to 96ce1ef Compare May 2, 2026 09:56
@Rua Rua marked this pull request as ready for review May 2, 2026 10:40
@Rua
Copy link
Copy Markdown
Contributor Author

Rua commented May 2, 2026

This can now be reviewed. It's a big change, certainly. But since it fixes a major pain point with macro expansion, maybe worth it?

@ahomescu ahomescu requested a review from fw-immunant May 7, 2026 03:34
@Rua Rua force-pushed the override_ty branch 4 times, most recently from 7b74610 to 28033ed Compare May 9, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transpile: const macros aren't translated with portable types

1 participant