Ice tests fix - #90
Merged
Merged
Conversation
AgnieszkaMakulska
commented
Jun 24, 2026
Contributor
- correct soluble_fraction and mean_r values, to have large dust INPs like before
- improving plots in ice tests
There was a problem hiding this comment.
Pull request overview
This PR adjusts the long-test “ice” scenarios to use updated aerosol parameters (soluble fraction and mean radius) intended to restore prior INP behavior, and refines the generated diagnostic plots (layout, units, and output formats).
Changes:
- Update aerosol
sol_fracandmean_rused by ice long tests to represent larger/less-soluble INPs. - Simplify and restyle the “scheme comparison” ice plot (now liquid/ice only, km on y-axis, PDF output, shared legend).
- Improve the SD ice profile plot presentation (km axis, grid, Celsius conversion, PDF outputs).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
long_test/test_plot_schemes_ice.py |
Updates aerosol params and revises scheme-comparison plotting to a 2-panel PDF with km scaling and shared legend. |
long_test/test_plot_ice_SD.py |
Updates plot styling/units, changes output files to PDF, and varies aerosol params per case. |
long_test/test_ice_SD.py |
Updates the aerosol parameters used for reference-consistency checks in the ice SD long test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.