Skip to content

Ice tests fix - #90

Merged
AgnieszkaMakulska merged 7 commits into
igfuw:masterfrom
AgnieszkaMakulska:ice
Jul 10, 2026
Merged

Ice tests fix#90
AgnieszkaMakulska merged 7 commits into
igfuw:masterfrom
AgnieszkaMakulska:ice

Conversation

@AgnieszkaMakulska

Copy link
Copy Markdown
Contributor
  • correct soluble_fraction and mean_r values, to have large dust INPs like before
  • improving plots in ice tests

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the long-test “ice” scenarios to use updated aerosol parameters (soluble fraction and mean radius) intended to restore prior INP behavior, and refines the generated diagnostic plots (layout, units, and output formats).

Changes:

  • Update aerosol sol_frac and mean_r used by ice long tests to represent larger/less-soluble INPs.
  • Simplify and restyle the “scheme comparison” ice plot (now liquid/ice only, km on y-axis, PDF output, shared legend).
  • Improve the SD ice profile plot presentation (km axis, grid, Celsius conversion, PDF outputs).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
long_test/test_plot_schemes_ice.py Updates aerosol params and revises scheme-comparison plotting to a 2-panel PDF with km scaling and shared legend.
long_test/test_plot_ice_SD.py Updates plot styling/units, changes output files to PDF, and varies aerosol params per case.
long_test/test_ice_SD.py Updates the aerosol parameters used for reference-consistency checks in the ice SD long test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread long_test/test_plot_ice_SD.py Outdated
@AgnieszkaMakulska
AgnieszkaMakulska merged commit b3395c8 into igfuw:master Jul 10, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants