Draft
Narrow zeroth-moment guard to the pow(0,0) corner case in parcel debug diagnostics#500
pow(0,0) corner case in parcel debug diagnostics#500Conversation
Co-authored-by: pdziekan <10848601+pdziekan@users.noreply.github.com>
Co-authored-by: pdziekan <10848601+pdziekan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job parcel_test (Debug, none)
Narrow zeroth-moment guard to the Aug 24, 2026
pow(0,0) corner case in parcel debug diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parcel_test (Debug, none)was failing inunit_test_debug/test_spectrum.py::test_spectrum_diff[dradii_dr_dry]after a recent change in SD moment counting. The regression came from broadxp == 0handling in the moment counter, which altered behavior beyond the intendedpow(0,0)NaN-avoidance fix.Root-cause correction
src/impl/diagnose_SD_attributes/particles_impl_moms.ipp, the fast path is now limited to the exact ambiguous case (xp == 0 && x == 0), instead of allxp == 0.Behavioral impact
pow(0,0)instability.x, avoiding unintended drift in debug spectrum outputs.Code change (minimal and localized)