Skip to content

Use binary wheels for Windows installer deps#43

Merged
ichwars merged 2 commits into
mainfrom
codex/fix-windows-installer-binary-wheels
Jul 25, 2026
Merged

Use binary wheels for Windows installer deps#43
ichwars merged 2 commits into
mainfrom
codex/fix-windows-installer-binary-wheels

Conversation

@ichwars

@ichwars ichwars commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • require binary wheels when installing dependencies into the Windows embeddable Python runtime
  • update greenlet from 3.2.5 to 3.3.2 in both lockfiles so CPython 3.13 Windows wheels are available
  • document the release-candidate packaging fix in the changelog

Why

The v1.2.6rc3 Windows Installer run verified the signed tag successfully, then failed while staging installer artifacts because greenlet 3.2.5 fell back to an sdist build against the Python embeddable distribution:

src/greenlet/greenlet.cpp(16): fatal error C1083: Cannot open include file: 'Python.h': No such file or directory
ERROR: Failed building wheel for greenlet

The embeddable distribution intentionally does not ship headers, so installer dependency staging should use prebuilt wheels only.

Verification

  • git diff --check
  • downloaded greenlet==3.3.2 as cp313-cp313-win_amd64 with --only-binary=:all:
  • verified that the downloaded Windows wheel SHA-256 is present in both lockfiles

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: faf25477fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread installers/windows/build.py Outdated
Comment thread requirements.lock.txt
@ichwars
ichwars merged commit 67dbbdc into main Jul 25, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant