IBX-11951: Removed ConfigResolver as unused implementation#764
Open
Steveb-p wants to merge 3 commits into
Open
IBX-11951: Removed ConfigResolver as unused implementation#764Steveb-p wants to merge 3 commits into
Steveb-p wants to merge 3 commits into
Conversation
…ase and updated references.
…vice definitions.
|
Steveb-p
changed the title
ibexa-workflow-automation-1
Bot
requested review from
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
alongosz
reviewed
Jun 19, 2026
Member
There was a problem hiding this comment.
Q: have you searched through documentation to check that we don't mention this class anywhere specifically? This is risky for 5.0, as there's some likelihood that someone uses it by accident. But if we don't document it indeed, I'd lean for +1.
Contributor
There was a problem hiding this comment.
This is worth checking indeed.
konradoboza
approved these changes
Jun 19, 2026
konradoboza
left a comment
konradoboza
left a comment
Contributor
There was a problem hiding this comment.
But proper sanities and potential doc usage scan is needed if we aim for 5.0.
bnowak
approved these changes
Jun 19, 2026
| * Make sure returned resource lists are not sorted as ResourceProvider is sorting them | ||
| * | ||
| * @return \Ibexa\Contracts\Core\SiteAccess\ConfigResolverInterface|\PHPUnit\Framework\MockObject\MockObject | ||
| * @return \Ibexa\Contracts\Core\SiteAccess\ConfigResolverInterface&\PHPUnit\Framework\MockObject\MockObject |
Contributor
There was a problem hiding this comment.
can we move this to native return type instead?
ViniTou
approved these changes
Jun 19, 2026
tbialcz
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
ConfigResolverwas not actually used.For QA:
Documentation: