refactor: remove duplicate separate_upper_class and with_common_respo…#801
Open
saiashok0981 wants to merge 1 commit into
Open
Conversation
…nse utility functions
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors shared utility helpers by relocating common response metadata and enum name formatting into shared utility modules, and updates call sites accordingly.
Changes:
- Removed
with_common_responsefromcommon.responsesand updated view imports to the new location. - Moved
separate_upper_classout ofapi.common.enumsinto a sharedcommon.utilsimport.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/api-engine/common/responses.py | Removes with_common_response, leaving only ok/err helpers. |
| src/api-engine/channel/views.py | Updates with_common_response import to new module path. |
| src/api-engine/chaincode/views.py | Updates with_common_response import while keeping ok from common.responses. |
| src/api-engine/api/common/enums.py | Replaces local separate_upper_class with shared import from common.utils. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
6
| def ok(data): | ||
| return {"data": data, "msg": None, "status": "successful"} | ||
|
|
||
|
|
||
| def err(msg): | ||
| return {"data": None, "msg": msg, "status": "fail"} |
| from channel.models import Channel | ||
| from channel.serializers import ChannelList, ChannelID, ChannelResponse, ChannelCreateBody | ||
| from common.responses import with_common_response | ||
| from api.utils.common import with_common_response |
| x += c | ||
| i += 1 | ||
| return "_".join(x.strip().split(" ")) | ||
| from common.utils import separate_upper_class |
Contributor
|
The commit needs a sign-off per policy required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nse utility functions