Fix: pass run identity on A5 dependency collector error close

[ChaoWao]

Problem and change

Main at 92a14e4e7 fails to build both A5 onboard runtimes after #2483: DeviceRunner::drain_execution still calls the old one-argument emit_device_dep_gen_graph on its boundary-wait discharge-error path, while the method requires three arguments.

Pass prepared.identity.run_epoch and false, matching the adjacent collector teardown's unsuccessful completion verdict. The original discharge_rc remains authoritative; this path does not certify a clean retained dependency-graph close.

This is a one-line build fix. No parameter API or planning documents are included.

Validation

• Reproduced on unmodified main with pip install --no-build-isolation -e .: both A5 runtime builds report no matching one-argument call.
• The full editable package/runtime build succeeds with the fix.
• Three existing C++ targets pass: test_a5_tmr_dep_gen_retained_runs, test_a5_tmr_dep_gen_run_identity, and test_a5_hbg_dep_gen_run_identity. The retained-run suite includes UnprovenCompletionPublishesNothing; these tests cover the collector contract, not an injected onboard discharge failure.
• All applicable pre-commit checks pass.
• No A5 onboard validation: architecture precheck identified A2/A3 silicon and refused A5 execution. No full scene sweep was run for this compile-time call-site repair.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 80d8bc74-282d-46f8-9a5e-312cf736aa87

📥 Commits

Reviewing files that changed from the base of the PR and between 92a14e4 and 82af70f.

📒 Files selected for processing (1)

• src/a5/platform/onboard/host/device_runner.cpp

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The discharge-error path in DeviceRunner::drain_execution now passes the current run epoch and an incomplete status to emit_device_dep_gen_graph.

Changes

Device error emission

Layer / File(s)	Summary
Pass run state on discharge errors src/a5/platform/onboard/host/device_runner.cpp	The discharge-error path passes the current run epoch and false to emit_device_dep_gen_graph.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 82af7

The incomplete run’s dependency graph is not published, and no material merge-blocking risk is established for this change.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: passing run identity on the A5 dependency collector error-close path.
Description check	✅ Passed	The description directly explains the build failure, the one-line fix, the completion-status behavior, and the reported validation results.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the run epoch with care,
Then marks the device graph incomplete there.
One call now carries both,
Through discharge errors’ path,
And hops away beneath the moonlit air.}

_{Comment @coderabbitai help to get the list of available commands.}