Repository navigation
kernels: use Metadata from kernels-data - #499
Merged
Merged
Conversation
danieldk
force-pushed
the
kernels-use-kernels-data
branch
from
April 22, 2026 14:12
5ef97fe to
4d498a1
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
danieldk
commented
Apr 22, 2026
| @@ -1,14 +1,4 @@ | |||
| [ | |||
Member
Author
There was a problem hiding this comment.
@adarshxs for sglang, it's better to change their flake to add torchVersions with this variant. The old variant is causing some issues in automatic version selection for devshells, etc.
danieldk
force-pushed
the
kernels-use-kernels-data
branch
from
April 22, 2026 18:13
8d12ee8 to
23856d1
Compare
This changeset combines a few related changes: - Use `Metadata` from `kernels-data` to ensure using the same metadata data structures in kernel-builder and kernels. - Make metadata mandatory and make several metadata fields mandatory, namely `id`, `version`, `license` the new `name` field. - Update the `build.toml` format to v4, making the required fields mandatory as well as the `torch-noarch` section for torch-noarch kernels. - Remove support for the very old v1 and v2 `build.toml` formats.
danieldk
force-pushed
the
kernels-use-kernels-data
branch
from
April 22, 2026 18:25
f4bfa3c to
1dfb2ac
Compare
danieldk
marked this pull request as ready for review
April 23, 2026 09:27
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset combines a few related changes:
Metadatafromkernels-datato ensure using the same metadata data structures in kernel-builder and kernels.id,version,licensethe newnamefield.build.tomlformat to v4, making the required fields mandatory as well as thetorch-noarchsection for torch-noarch kernels.build.tomlformats.LoadedKernel, add metadata and removemodule_name(can be queried from the metadata).RepoInfostoRepoInfo.