Conversation
drbh
force-pushed
the
port-causal-conv1d
branch
from
August 26, 2026 23:59
36e7765 to
8f18396
Compare
Collaborator
Author
|
/kernel-bot build-and-stage causal-conv1d |
drbh
force-pushed
the
port-causal-conv1d
branch
from
August 27, 2026 00:18
8f18396 to
59556c9
Compare
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
Signed-off-by: David Holtz <david.richard.holtz@gmail.com>
drbh
force-pushed
the
port-causal-conv1d
branch
from
August 27, 2026 14:24
59556c9 to
8949293
Compare
Contributor
|
Hi @drbh, heads-up on a conflict: #1079 (merged last week, 1a0b434) added a SYCL/XPU backend to causal-conv1d, but this PR's base predates that merge — the recipe here has manifest backends="cuda" and no SYCL sources, so regenerating src would drop the XPU backend. Since XPU has no upstream equivalent in Dao-AILab/causal-conv1d, prune keep=... won't preserve it. So can you help fold it into the recipe? Thx! |
Collaborator
Author
|
closing until the first port is landed since the porting language is in flux until merged. thanks for the heads up @kaixuanliu, I will make sure to keep this in mind when reopening the port pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr refers porting causal conv1d