Skip to content

Keyboard fixes #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandiyosDev merged 3 commits into from
Aug 7, 2026
Merged

Keyboard fixes #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c589da7
send the key release too when shift is held
SandiyosDev Aug 7, 2026
7c2f548
toolbar button target
SandiyosDev Aug 7, 2026
266dc2d
there is no font called System, key captions were falling back to 17pt
SandiyosDev Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions OpenParsec/ParsecSDKBridge.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,8 @@ class ParsecSDKBridge: ParsecService {
}
var keyboardMessagePress = ParsecMessage()
keyboardMessagePress.type = MESSAGE_KEYBOARD
if !isVirtualShiftOn && useShift {
let sendShift = !isVirtualShiftOn && useShift
if sendShift {
keyboardMessagePress.keyboard = ParsecKeyboardMessage(code: KEY_LSHIFT, mod: MOD_NONE, pressed: true, __pad: (0, 0, 0))
ParsecClientSendMessage(_parsec, &keyboardMessagePress)
}
Expand All @@ -452,10 +453,11 @@ class ParsecSDKBridge: ParsecService {
// add release delay in case some games ignore instant key release
DispatchQueue.global().asyncAfter(deadline: .now() + 0.02) {
keyboardMessagePress.keyboard = ParsecKeyboardMessage(code: keyCode, mod: MOD_NONE, pressed: false, __pad: (0, 0, 0))
if !self.isVirtualShiftOn && useShift {
ParsecClientSendMessage(self._parsec, &keyboardMessagePress)
if sendShift {
keyboardMessagePress.keyboard = ParsecKeyboardMessage(code: KEY_LSHIFT, mod: MOD_NONE, pressed: false, __pad: (0, 0, 0))
ParsecClientSendMessage(self._parsec, &keyboardMessagePress)
}
ParsecClientSendMessage(self._parsec, &keyboardMessagePress)
}
}

Expand Down
4 changes: 2 additions & 2 deletions OpenParsec/ParsecViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,7 +1161,7 @@ extension ParsecViewController: UIKeyInput, UITextInputTraits {

// Set the image and button properties
button.setTitle(displayText, for: .normal)
button.titleLabel?.font = UIFont(name: "System", size: 10.0)
button.titleLabel?.font = .systemFont(ofSize: 10)
button.frame = CGRect(x: 0, y: 0, width: 36, height: 36)
button.titleLabel?.frame = CGRect(x: 0, y: 0, width: 30, height: 30)
if let label = button.titleLabel {
Expand All @@ -1173,7 +1173,7 @@ extension ParsecViewController: UIKeyInput, UITextInputTraits {
button.titleLabel?.contentMode = .scaleAspectFit

// Set target and action for button
button.addTarget(target, action: #selector(toolbarButtonClicked(_:)), for: .touchUpInside)
button.addTarget(self, action: #selector(toolbarButtonClicked(_:)), for: .touchUpInside)

return button
}
Expand Down
Loading