Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

added inside callback for geofences#294

Open
codearachnid wants to merge 3 commits into
hpneo:masterfrom
codearachnid:master
Open

added inside callback for geofences#294
codearachnid wants to merge 3 commits into
hpneo:masterfrom
codearachnid:master

Conversation

@codearachnid

Copy link
Copy Markdown

I wanted to be able to track movements between the fence not just if position crossed ouside threshhold. So by adding an option for an inside callback it can now track in either direction and callback if marker stays within or ouside boundary on movement.

@codearachnid

Copy link
Copy Markdown
Author

I apologize for the 3 commits - was using the github web api to make these edits since I don't have access to run the git repo locally and commit.

@xenda

xenda commented Mar 10, 2014

Copy link
Copy Markdown
Collaborator

This looks interesting. Would you mind adding a test for it?

@codearachnid

Copy link
Copy Markdown
Author

I can work on including a test for it. I didn't see any existing geofence tests and this just extends the current implementation to subscribe to movements in/out.

@ncacace

ncacace commented Aug 25, 2017

Copy link
Copy Markdown

Suggestion:
Instead of 'Outside' and 'Inside'
Why not true/false switch for current outside option since you're either inside or outside and then add it as a parameter..?

This would be useful if you're waiting for someone to arrive and wanted to be notified if they arrived within a certain range of a perimeter for example

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants