refactor(imp): retire 'hashtable' IMAP cache driver, fall through to 'cache'#61
Merged
ralflang merged 2 commits intoJun 9, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'hashtable' driver in
IMP_Imap_Cache_Wrapperis retired. Existing configurations that setcache.driver = 'hashtable'for the IMAP cache fall through to the 'cache' branch, which usesHorde_Cache(which can itself be backed by the modern HashTable).Rationale: see horde/Imap_Client#46 — the per-UID
Backend_Hashtablestrategy was justified for Memcache 1.0 with poor multi-get; modern Redis handles the sliced strategy ofBackend_Cacheequally well. One code path with consistent TTL/age handling is preferable to two.No config change required for existing deployments.
Refs horde/Core#131