fix(cliff): add the tag_pattern to ignore non-release tags - #28
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 43 minutes and 29 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughA git-cliff configuration file was modified to add a 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pre-1.0-cliff.toml`:
- Around line 85-86: The tag_pattern value is wrong: the patch component lacks a
+ quantifier and the pattern is unanchored; update the tag_pattern key so it
uses a proper regex (e.g. for final release-only tags set tag_pattern =
"^v?[0-9]+\\.[0-9]+\\.[0-9]+$" or, if you intend to include pre-releases, use
"^v?[0-9]+\\.[0-9]+\\.[0-9]+") to match the behavior used/expected by
prepare_release.rs (see how it distinguishes anchored final-release vs
unanchored pre-release patterns); replace the current tag_pattern string
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
45d46ad to
e7f051f
Compare
|
✔️ e7f051f - Conventional commits check succeeded. |
Currently, all tags are matched and added to the changelog but that breaks the
--bumplogic of git-cliff because it takes a tag likemain-<sha>and doesn't know how to bump it. With this change any unmatched tags are ignored and the commits under it are added to the next valid commit, that means that given the following:gitGraph: commit id: "1" commit id: "2" tag: "main-2" commit id: "3" commit id: "4" tag: "v0.1.0" commit id: "5"Commits
1,2,3, and4are all added to the changelog under thev0.1.0tag. Then, if running with--bumpthen a new entry will be added to the changelog with commit5underv0.1.1.