chore: add option to skip pre-release checks - #26
Conversation
|
✔️ 4423dad - Conventional commits check succeeded. |
WalkthroughThe pull request adds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/release_util/src/lib.rs`:
- Around line 49-57: get_released_version_tag's Err branch currently treats all
failures as "no previous release"; change it to distinguish the known "no
previous release" sentinel from other operational errors by inspecting the error
(from get_released_version_tag / get_version_from_cliff_output). Specifically,
match Err(e) and if e.to_string() (or pattern-match the error variant if
available) equals or contains "No value in git-cliff output list" then print the
existing "No previous release found, skipping semver checks" message and
continue, otherwise propagate the error (return Err(e) or use ?), so real
failures from git-cliff, JSON parsing, etc. are not silently ignored; keep
references to get_released_version_tag, get_version_from_cliff_output,
get_revision_for_tag, and run_semver_checks to locate the code.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
crates/integration/src/lib.rscrates/release_util/src/bin/holochain_release_util.rscrates/release_util/src/lib.rs
I think this was previously requested, and it's time to add it. Sometimes the baseline just won't build, and it's not our fault. These are nice to have, not absolutely required on dev releases.
Summary by CodeRabbit
--skip-semver-checkscommand-line flag to the release utility, enabling users to bypass semantic versioning validation checks during the release preparation process. When activated, a warning message is displayed instead of enforcing version constraints.