You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds peer_unresponsive to GossipStateSummary, which is exposed in holochain's dump_network_metrics call. This is helpful in diagnosing behavior with unresponsive peers.
Putting this field in GossipStateSummary isn't really the right place as it's not specifically related to gossip behavior. I'm not sure if that's worth addressing here.
Added a new peer_unresponsive field to the PeerMeta struct in the API crate to track peer unresponsiveness status. Updated the gossip summary generation to populate this field by retrieving unresponsive state from the peer metadata store.
Added public field peer_unresponsive: Option<Timestamp> to PeerMeta struct to store unresponsiveness timestamp metadata
Gossip summary population crates/gossip/src/summary.rs
Updated PeerMeta construction in K2Gossip::summary to load and populate peer_unresponsive field via async call to get_unresponsive(url) from peer_meta_store
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Straightforward field addition across two related files with consistent pattern
New async operation introduced (await get_unresponsive()) requires verification of error handling and propagation
Consider reviewing the async call semantics and whether error propagation is appropriate in the summary generation context
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Title Check
✅ Passed
The pull request title "feat: include peer_unresponsive timestamp in GossipStateSummary" is directly aligned with the changes made. The PR adds a new peer_unresponsive: Option<Timestamp> field to the PeerMeta struct in the gossip API and populates it within the K2Gossip::summary function. The title is concise, clear, and accurately reflects the primary change without being misleading or overly vague. It uses a conventional feature commit convention and specifically names the key technical detail (peer_unresponsive timestamp) that developers would recognize when reviewing the repository history.
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/peer_unresponsive-in-network-info
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
peer_unresponsiveto GossipStateSummary, which is exposed in holochain'sdump_network_metricscall. This is helpful in diagnosing behavior with unresponsive peers.Putting this field in
GossipStateSummaryisn't really the right place as it's not specifically related to gossip behavior. I'm not sure if that's worth addressing here.