Skip to content

fix: upload GitHub artifacts from dir instead of names from stdout - #26

Merged
cdunster merged 1 commit into
mainfrom
25-nodejs-publish-github-release-step-fails-when-the-package-has-a-prepare-script
Aug 5, 2026
Merged

fix: upload GitHub artifacts from dir instead of names from stdout#26
cdunster merged 1 commit into
mainfrom
25-nodejs-publish-github-release-step-fails-when-the-package-has-a-prepare-script

Conversation

@cdunster

@cdunster cdunster commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Sometimes the stdout would be polluted so it was not a reliable way to get the NPM packed artifacts, instead pack into a directory and upload all tarball files from that dir.

Tested with: https://github.com/holochain/npm-release-test/actions/runs/30992475128/job/92261642829.

Closes #25.

Sometimes the stdout would be polluted so it was not a reliable way to
get the NPM packed artifacts, instead pack into a directory and upload
all tarball files from that dir.
@cdunster
cdunster requested a review from a team August 5, 2026 09:22
@cdunster cdunster self-assigned this Aug 5, 2026
@cocogitto-bot

cocogitto-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

✔️ d9f37ff - Conventional commits check succeeded.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b91c2e60-e679-4fe5-8e91-50abaa592241

📥 Commits

Reviewing files that changed from the base of the PR and between 53f074d and d9f37ff.

📒 Files selected for processing (1)
  • nodejs-publish/action.yml

Walkthrough

The pack step now writes npm tarballs to a temporary directory and exposes that directory as pack_dir. GitHub release handling now enumerates and uploads all .tgz files from the directory for both existing and newly created releases. Tarball filename parsing and per-tarball iteration were removed.

Suggested reviewers: jost-s

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary fix: uploading GitHub artifacts from a directory instead of parsing names from stdout.
Description check ✅ Passed The description explains the stdout pollution problem, the directory-based fix, testing, and closure of issue #25.
Linked Issues check ✅ Passed The changes address issue #25 by packing artifacts into a directory and uploading all .tgz files, including workspace artifacts.
Out of Scope Changes check ✅ Passed The changes are limited to the artifact packing and GitHub release upload flow described in issue #25.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 25-nodejs-publish-github-release-step-fails-when-the-package-has-a-prepare-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cdunster
cdunster merged commit 77382c5 into main Aug 5, 2026
5 checks passed
@cdunster
cdunster deleted the 25-nodejs-publish-github-release-step-fails-when-the-package-has-a-prepare-script branch August 5, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nodejs-publish: GitHub release step fails when the package has a "prepare" script

2 participants