Skip to content

Fix previous tag detection in this repo's release automation - #23

Merged
cdunster merged 3 commits into
mainfrom
ci/fix-previous-tag-detection
Jul 6, 2026
Merged

Fix previous tag detection in this repo's release automation#23
cdunster merged 3 commits into
mainfrom
ci/fix-previous-tag-detection

Conversation

@cdunster

@cdunster cdunster commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Creating a new release via the GH API uses the previous tag on the current branch by default but the release workflow resets the stable branch just before creating a release which means the previous tag was not on this branch and therefore not detected correctly.

Also do some small boy-scouting.

cdunster added 3 commits July 2, 2026 16:55
Creating a release uses the previous tag on this branch by default but
the branch is reset just before a release which means the previous tag
was not on this branch.
@cdunster cdunster self-assigned this Jul 2, 2026
@cocogitto-bot

cocogitto-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

✔️ 2e71fcd...65eb966 - Conventional commits check succeeded.

@cdunster
cdunster requested a review from a team July 2, 2026 14:59
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 31383155-8a68-46d1-869a-e934d8575c3c

📥 Commits

Reviewing files that changed from the base of the PR and between 569e2bb and 65eb966.

📒 Files selected for processing (2)
  • .github/workflows/release-actions.yml
  • nodejs-publish/action.yml

Walkthrough

Changes

This pull request modifies two GitHub Actions workflow files. In release-actions.yml, a new step computes the most recent existing git tag and passes it to gh release create via a --notes-start-tag argument, adjusting the range used for auto-generated release notes. In nodejs-publish/action.yml, the version-extraction step is rewritten as a multiline script reading the version from package.json, and the gh release upload command gains a --clobber flag to allow overwriting existing release assets.

Sequence Diagram(s)

Not applicable; changes are limited to workflow configuration without new runtime component interactions beyond CI step ordering shown above.

Suggested reviewers: ThetaSinner, jost-s

Compact metadata:

  • Repository: holochain/actions
  • PR number: 23
  • Files changed: 2
  • Lines changed: +13/-2

Related issues: None specified
Related PRs: None specified
Suggested labels: None specified

Poem:

  • A tag was found, sorted with care,
  • Release notes now know where to compare.
  • The version script grew a line or two,
  • And --clobber lets old assets make way for new.
  • Small hops, this rabbit's workflow refined anew. 🐇
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change to release automation and previous tag detection.
Description check ✅ Passed The description is directly related to the tag-detection fix and mentions the small housekeeping changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/fix-previous-tag-detection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cdunster
cdunster merged commit d4681f3 into main Jul 6, 2026
5 checks passed
@cdunster
cdunster deleted the ci/fix-previous-tag-detection branch July 6, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants