Skip to content

Fix Baseline Inference code after MCIF HF repo update - #41

Merged
mgaido91 merged 7 commits into
mainfrom
fix_baseline_repo_path
Jul 17, 2026
Merged

Fix Baseline Inference code after MCIF HF repo update#41
mgaido91 merged 7 commits into
mainfrom
fix_baseline_repo_path

Conversation

@sarapapi

@sarapapi sarapapi commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

In the recent MCIF repo update, the xml src files have been removed. However, the baselines code has not been updated.
This PR loads the dataset directly from huggingface, addressing #40 altogether.

Closes #40

@sarapapi
sarapapi requested a review from mgaido91 July 13, 2026 13:34
@sarapapi sarapapi changed the title Add try-except given the new version-less naming of the MCIF xml files Fix versionless MCIF xml files in baselines Jul 13, 2026
@sarapapi sarapapi self-assigned this Jul 13, 2026
@sarapapi sarapapi added the bug Something isn't working label Jul 13, 2026
@sarapapi
sarapapi marked this pull request as draft July 13, 2026 13:37
@sarapapi sarapapi linked an issue Jul 13, 2026 that may be closed by this pull request
@sarapapi
sarapapi marked this pull request as ready for review July 13, 2026 16:15
@sarapapi sarapapi changed the title Fix versionless MCIF xml files in baselines Fix Baseline Inference code after MCIF HF repo update Jul 13, 2026

@mgaido91 mgaido91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart one comment

Comment thread pyproject.toml Outdated
@mgaido91

Copy link
Copy Markdown
Contributor

edit the description to include "Closes #issueID", so the corresponding issue is automatically closed when merging this.

@mgaido91
mgaido91 merged commit 4717152 into main Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revisit baseline code

2 participants