Repository navigation
inference: rename read-spec field site to point - #244
Merged
Merged
Conversation
`NPReadSpec.site` becomes `point` and `NPCaptureSite` becomes `NPCapturePoint`. The value has always been an interp-engine point name that goes straight into an `Address`, and the engine calls that a point; `site` was a second word for the same thing. Renamed now while the field is two weeks old and the SDK publish is off, so nothing outside the repo reads it. A contract test pins every member to the engine's layer-scoped d_model points, spelled the engine's way, so the webapp -- which gets the enum only through the generated `inference.d.ts` -- cannot drift from the engine without failing here. The stored `projectionParams.read.site` key on existing `Vector` rows needs a data migration to `read.point`; the seven rows in production all carry it. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPReadSpec.sitetopointandNPCaptureSitetoNPCapturePointin the inference server, with the internalCaptureSite/CaptureKey.site/ReadSpec.sitefollowing.apps/inference/openapi.jsonandapps/webapp/lib/api/inference.d.ts.personaAxisToVectorReadsendsread.point; test and schema comment updated.tests/unit/test_capture_point_contract.py: everyNPCapturePointmember is a layer-scopedd_modelinterp-engine point, spelled the engine's way.Stored
Vector.projectionParams.read.siterows getread.pointvia a direct SQL update; the old key can stay until removed.