Repository navigation
fix(webapp): gemma-2-2b default graph follows the selected source set - #243
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Switching source sets on the gemma-2-2b graph page reloads to
/gemma-2-2b/graph?sourceSet=<name>with noslug. The no-slug branch then hardcodesgemma-fact-dallas-austin, agemmascope-transcoder-16kgraph, regardless of the selected source set. Its pinned ids and supernodes (20_15589_*etc.) are transcoder feature ids, so onclt-hpthe page showed a graph from the wrong source set.Fix
In
apps/webapp/app/[modelId]/graph/page.tsx, whenmodelId === 'gemma-2-2b'and the resolved source set isclt-hp, pickfactthecapitalof-1789506352829instead. That graph is not featured, so it is not in the preloaded metadata map for most visitors; the pick falls back to the sameprisma.graphMetadata.findUniquelookup theslugbranch uses and adds it to the map.Every other source set keeps the existing
gemma-fact-dallas-austinpick, unchanged.Checks
prettier --check,eslint(pre-existinganywarnings only),tsc --noEmitpass.Made with Cursor