fix(fonts): resolve observed family aliases deterministically#2768
Open
jrusso1020 wants to merge 2 commits into
Open
fix(fonts): resolve observed family aliases deterministically#2768jrusso1020 wants to merge 2 commits into
jrusso1020 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolve production-observed font-family spellings that are currently renderable
but fail deterministic distributed font preflight:
script-compatible Google families
Futura StdandMS Sans Serifthrough the existing bundled-fontsubstitution path
a family the producer can resolve
Unknown families still fail closed.
Why
font_unresolvedis the largest current Hyperframes failure class. In afresh six-hour production sample it accounted for 49 completion failures. The
underlying exception logs included retries; deduplicating by workflow showed
28 affected workflows across 11 family spellings. This PR covers 22 of those
28 workflows:
MS Sans Serif,Noto Sans Greek,Pretendard, andYantra Manav);FredericktheGreat,Noto Serif VI, andPyidaungsu).The remaining
Fira GO,Bungee Stencil, andYantraavishkarspellings stayfail-closed because substituting them would risk changing script coverage or
typography.
inheritis a CSS cascade/parser issue and is intentionally leftfor a separate syntax-aware fix.
The Google CSS2 endpoint does not serve several observed names verbatim even
though a deterministic script-compatible family exists. The producer therefore
reported a customer
font_unresolvederror for content it can safely render.How
GOOGLE_FONT_FAMILY_ALIASESmap in the browser-safe parserspackage
@font-facerulesunder the original authored family, so existing CSS selectors still match
FONT_ALIAS_MAP, whose values mean bundled fontsubstitutions
font_family_without_font_faceThe exact production axis matrix was verified against the official Google Fonts
CSS2 endpoint for every mapped family.
Pyidaungsumaps to script-compatibleNoto Sans Myanmar; it is not metrically identical and must be included incandidate screenshot/parity monitoring.
Test plan
Validation:
every new alias
commit-message hooks passed
extension with no blockers