test(core): cover video timing StaticGuard regression#2747
Draft
phucsd1 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<video>elementdata-start="6" data-duration="8"is compiled todata-end="14"Why
Issue #2662 originally demonstrated the regression with audio. An A/B investigation of a real video composition found the same failure mode for
<video>: v0.7.64 emitteddata-endduring compilation and StaticGuard then rejected the compiled result for not retainingdata-duration. Releases v0.7.65 through v0.7.68 no longer reproduce it.This PR adds video coverage to prevent that path from regressing. It is test-only and does not change runtime behavior.
Investigation details: #2662 (comment)
Verification
[StaticGuard] Invalid HyperFrame contract: <video id="demo"> uses data-end without data-duration.packages/core/src/compiler/htmlBundler.test.tspasses 44/44 on currentmainoxfmtandoxlintpass for the changed filepackages/coreandpackages/studio