feat: multi-factor attachment support for Advanced dbs (W-21632630)#3655
Draft
feat: multi-factor attachment support for Advanced dbs (W-21632630)#3655
Conversation
- new backward-compatible lib function 'parseAttachmentFactors' - unit tests for the parser function
- improvements on the interactive experience - fixed all tests with the new behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Here we introduce updates to support Multi-Factor Attachments on NGPG commands.
The main changes revolve around:
parseAttachmentFactorsthat parses attachment namespace strings into role / pool / proxy (pipe-separated, backward-compatible with single-factor attachments). Includes unit tests.data:pg:attachments:createnow prompts for non-provided flag option values. For non-interactive experience, allpool,credentialandasflags option values need to be specified. Missing values will be interactively prompted.data:pgtopic commands where updated to stop relying on exact namespace === "role:…" (and similar) comparisons and use parsed factors forcredentialstopic (list,rotate,destroy),infoandattachmentscommands. Other related helpers/types were updated for compatibility.data:pg:psqlcommand drops the credential flag so connection selection fits multi-factor attachments.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Steps:
Screenshots (if applicable)
Related Issues
GUS work item: W-21632630