Skip to content

feat: multi-factor attachment support for Advanced dbs (W-21632630)#3655

Draft
sbosio wants to merge 7 commits intomainfrom
sbosio/multi-factor-attachments
Draft

feat: multi-factor attachment support for Advanced dbs (W-21632630)#3655
sbosio wants to merge 7 commits intomainfrom
sbosio/multi-factor-attachments

Conversation

@sbosio
Copy link
Copy Markdown
Contributor

@sbosio sbosio commented Apr 8, 2026

Summary

Here we introduce updates to support Multi-Factor Attachments on NGPG commands.

The main changes revolve around:

  • Introduction of a new library function: parseAttachmentFactors that parses attachment namespace strings into role / pool / proxy (pipe-separated, backward-compatible with single-factor attachments). Includes unit tests.
  • data:pg:attachments:create now prompts for non-provided flag option values. For non-interactive experience, all pool, credential and as flags option values need to be specified. Missing values will be interactively prompted.
  • Other data:pg topic commands where updated to stop relying on exact namespace === "role:…" (and similar) comparisons and use parsed factors for credentials topic (list, rotate, destroy), info and attachments commands. Other related helpers/types were updated for compatibility.
  • data:pg:psql command drops the credential flag so connection selection fits multi-factor attachments.
  • Tests & fixtures were updated adding new tests for multi-factor attachments and the new interactive prompting behavior.

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

Notes:

Steps:

  1. Replace this text with a list of steps used to validate changes or type 'Passing CI suffices'.
  2. ...

Screenshots (if applicable)

Related Issues

GUS work item: W-21632630

@sbosio sbosio requested a review from a team as a code owner April 8, 2026 18:46
@sbosio sbosio marked this pull request as draft April 8, 2026 18:46
@sbosio sbosio temporarily deployed to AcceptanceTests April 10, 2026 22:26 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests April 10, 2026 22:26 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests April 10, 2026 22:26 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests April 10, 2026 22:26 — with GitHub Actions Inactive
@sbosio sbosio requested a review from asrivastava13 April 10, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant