harvester-csi-driver-lvm: grant snapshot location ConfigMap permissions - #596
Open
WebberHuang1118 wants to merge 1 commit into
Open
harvester-csi-driver-lvm: grant snapshot location ConfigMap permissions#596WebberHuang1118 wants to merge 1 commit into
WebberHuang1118 wants to merge 1 commit into
Conversation
WebberHuang1118
marked this pull request as ready for review
August 18, 2026 08:11
WebberHuang1118
requested review from
a team,
Vicente-Cheng,
ibrokethecloud and
starbops
as code owners
August 18, 2026 08:11
Signed-off-by: Webber Huang <webber.huang@suse.com>
WebberHuang1118
force-pushed
the
issue-11339
branch
from
August 19, 2026 06:27
6d1e703 to
804aa18
Compare
ibrokethecloud
approved these changes
Aug 19, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The LVM CSI driver now persists each snapshot's node and volume-group location in a namespaced ConfigMap. The packaged Harvester LVM CSI chart does not grant the
harvester-csi-driver-lvmservice account permission to manage those location records, so snapshot creation and annotation-free pre-existing snapshot deletion cannot use the registry.Solution
Add a namespace-scoped Role and RoleBinding to
charts/harvester-csi-driver-lvm, granting its existing service account onlyget,create, anddeleteaccess to ConfigMaps.Impact
The packaged LVM driver can create, resolve, and remove per-snapshot location records without receiving cluster-wide ConfigMap permissions. The generic
harvester-csi-driverchart is unchanged.Validation
helm lint charts/harvester-csi-driver-lvmhelm template harvester-csi-driver-lvm charts/harvester-csi-driver-lvm --namespace harvester-systemhelm lint charts/harvester-csi-driverhelm template harvester-csi-driver charts/harvester-csi-driver --namespace kube-systemgit diff --checkRelated to harvester/harvester#11339.