Repository navigation
Limit host execution to Git; keep diagnostic test output private - #25
Merged
Merged
Conversation
9 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to merged Docker isolation PR #24. Remove all non-Git executables from the host subprocess runner and only permit the app required Git subcommands; suppress GIT_ / SSH_ / LD_ / DYLD_ and other injection-prone host environment. Raw test stdout, which can contain stack traces and credentials, is no longer sent through the unauthenticated HTTP API. Instead it is appended to a private local workspace test-output.log with O_NOFOLLOW and mode 0600; HTTP returns execution code and generic notice. Add regression tests blocking host pytest/python/git-config execution and verifying secret-bearing tracebacks never reach /api/execute. 61 backend tests pass locally. This addresses CodeQL alert #5 (command-line input) and medium stack trace disclosure alerts #6/#7; await independent CodeQL checks, do not dismiss findings without verification. Production multi-user authentication and container threat review still outstanding.