Repository navigation
Reject leases that expire while waiting for the SQLite writer lock - #5
Merged
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduced failure
Lease operations sampled the clock before BEGIN IMMEDIATE. A competing writer could hold the lock until the lease expired, after which complete/heartbeat/fail still accepted the old timestamp. Claim intervals and enqueue delays also included lock-wait time.
Fix
Sample time inside the acquired write transaction. Refresh claim selection time for each cleanup candidate. Preserve owner/fence/status predicates and atomic job/event writes. No database schema migration.
Six deterministic-clock tests contend against a real SQLite writer lock. All six fail on fd5a99a and pass with the fix; rejected operations leave state/events unchanged and remain reclaimable with a fresh fence.
Verification before push
Includes an executable failure analysis, corrected architecture notes, CodeQL workflow and 0.1.3 patch-release metadata. Existing Python 3.11–3.13 CI, packaging, benchmark smoke, lint and CodeQL must pass before merge.
Limits
Time is checked during the write transaction, not at response delivery. Process pauses, slow commits, wall-clock adjustments and external side effects remain outside hard deadline/exactly-once guarantees. This is a correctness fix, not a new performance claim.