Skip to content

fix: channelBadgeText dev->DEV / beta->BETA, publish.yml dev->dev - #263

Closed
jack-champagne wants to merge 2 commits into
local/amicodefrom
fix/titlebar-dev-beta-badge
Closed

fix: channelBadgeText dev->DEV / beta->BETA, publish.yml dev->dev#263
jack-champagne wants to merge 2 commits into
local/amicodefrom
fix/titlebar-dev-beta-badge

Conversation

@jack-champagne

@jack-champagne jack-champagne commented Aug 27, 2026

Copy link
Copy Markdown
Member

Split dev/beta badges — internal dev builds (DEV) vs store beta (BETA).

  • packages/app/src/components/titlebar-channel.ts:8 — was ["beta","dev"].includes -> BETA (both collapsed), now dev->DEV / beta->BETA / prod->null; developerEnabled still forces DEV.
  • packages/app/src/components/titlebar-channel.test.ts:11 updated
  • .github/workflows/publish.yml:317 — was (beta && beta)||prod so dev branch built as prod (no badge). Now beta&&beta || dev&&dev || prod + VITE_SENTRY_ENVIRONMENT dev. Desktop: dev=>DEV, updater OFF (desktop/src/main/constants.ts:7), beta=>BETA, updater ON.

Companion skill fix: harmoniqs/armonissima#77.

BETA for external releases, dev for internal.

Summary by CodeRabbit

  • Bug Fixes
    • Development builds now use the correct development channel and environment settings.
    • The application’s channel badge now displays “DEV” for development builds instead of incorrectly showing “BETA.”
    • Beta builds continue to display the “BETA” badge.

Pre-2026-08-27 channelBadgeText collapsed dev+beta to BETA and
publish.yml mapped dev branch to prod (no badge). Fix: dev->DEV
(internal, updater OFF), beta->BETA (store, updater ON), prod->no
badge. See amicode-release skill fix (armonissima#77).
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 44 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9aca3d45-51ed-4a01-a884-7bf9dc7532e5

📥 Commits

Reviewing files that changed from the base of the PR and between 53bd437 and 662ae1c.

📒 Files selected for processing (1)
  • .github/workflows/amicode-release.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ce4c17e-013f-4850-8655-118dfb47d28b

📥 Commits

Reviewing files that changed from the base of the PR and between d10efbd and 53bd437.

📒 Files selected for processing (3)
  • .github/workflows/publish.yml
  • packages/app/src/components/titlebar-channel.test.ts
  • packages/app/src/components/titlebar-channel.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The dev branch now maps to dev build channels and the dev Sentry environment. The titlebar displays DEV for the dev channel and keeps BETA for the beta channel. Tests validate the updated badge behavior.

Changes

Dev channel differentiation

Layer / File(s) Summary
Channel badge behavior
packages/app/src/components/titlebar-channel.ts, packages/app/src/components/titlebar-channel.test.ts
channelBadgeText returns DEV for the dev channel and BETA for the beta channel when developer mode is off. The test expectations reflect the separate badges.
Publish environment mapping
.github/workflows/publish.yml
The Prepare, Build, Package, and Package (no publish) steps map the dev branch to the dev channel. The Build step maps it to the dev Sentry environment.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 53bd4

This change separates internal DEV builds from BETA and production labeling and telemetry classification. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: jeonghun-jj-lee, brendonovich

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the main implementation and intended behavior, but it omits several required template sections: issue reference, change type, verification steps, screenshots or an explicit no… Complete the template. Add the issue reference, select the change type, describe how the changes were verified, add screenshots or state that they are not applicable, and complete both checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies both main changes: separate DEV and BETA badge text and map the dev branch to the dev publish channel.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the main implementation and intended behavior, but it omits several required template sections: issue reference, change type, verification steps, screenshots or an explicit not-applicable statement, and checklist confirmation.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/titlebar-dev-beta-badge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Fork binaries were always dev (DEV badge). Store external releases
need BETA. Add workflow_dispatch channel choice (default dev) so
amicode can request beta for clean tags via cross-repo dispatch:

  gh workflow run amicode-release.yml --repo harmoniqs/opencode -f tag=v1.18.10-amicode.19 -f channel=beta

OPENCODE_CHANNEL now inputs.channel or dev, release notes badge,
and a channel/b Badge gate (grep VITE_OPENCODE_CHANNEL) alongside
the existing newLayoutDesigns ON gate.

See harmoniqs/armonissima#77 and titlebar-channel.ts:8.
@jack-champagne

Copy link
Copy Markdown
Member Author

Merged via direct push to local/amicode (e94eb7d) — OAuth App workflow scope blocked PR merge. Changes are live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant