chore(app-bundle): sync manifest for bug-dock focus fix (amicode#478) - #545
Merged
Conversation
CI app-bundle-gate was failing after 9s: overlay file hash mismatch (hand-edit?): packages/app/src/pages/session/composer/session-bug-dock.tsx — re-run the extractor The 4e7c2f4 fix edited the overlay directly; manifest still had the pre-fix hash (e7fed3c5 from v1.18.10-amicode.16). Sync the hash to the current overlay (4b56c464) — same pattern as dbeef49 for #481.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe app bundle manifest now records an updated hash for ChangesManifest integrity
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized manifest synchronization change; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI
app-bundle-gatefailing after 9s onmain:Root cause: commit
4e7c2f4(#544) editedoverlay/.../session-bug-dock.tsxdirectly (focus + border fix) but leftmanifest.jsonat the pre-fix hashe7fed3c5(fromv1.18.10-amicode.16). The drift gate's committed-state check (the only check on public CI where the fork clone is absent) correctly flagged the divergence — same pattern as #481.Fix: sync
manifest.jsonhash for that file to the current overlay (4b56c464).node packages/app-bundle/scripts/drift_gate.mjs→PASS(502 files)Followed the same chore pattern as
dbeef49for #481.Summary by CodeRabbit