BUG/MINOR: Prevent user addition with whitespace in password hash - #792
Open
markkrj wants to merge 2 commits into
Open
BUG/MINOR: Prevent user addition with whitespace in password hash#792markkrj wants to merge 2 commits into
markkrj wants to merge 2 commits into
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
markkrj
changed the title
oktalz
force-pushed
the
fix-user-password
branch
from
August 14, 2026 09:23
e265c35 to
18f9085
Compare
If password contains whitespace of any kind, haproxy fails to validate the config and will not start or reload
oktalz
force-pushed
the
fix-user-password
branch
from
August 26, 2026 11:10
18f9085 to
7713940
Compare
oktalz
requested changes
Aug 26, 2026
Member
|
hi @markkrj |
…words The ingress controller would panic when auth-type/auth-secret are confgured through ConfigMap. Secret name and namespace was added to the message to enhance context.
Author
|
@oktalz What do you think of this approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If password hash contains whitespace of any kind, haproxy fails to validate the config and will not start or reload.
According to
man 5 crypt:I don't know if it must be this controller's job to validate all of that. But, whitespace in the password does brake it from generating valid HAProxy config, so that is a bug.
Also, I think that emitting a warning is helpful for admins to figure out why some user cannot login.
/cc @ivanmatmati: I talked to you on Slack
/cc @hdurand0710: You fixed a bug related