.distignore の src を行頭アンカーし vendor 配下の誤除外を防ぐ#56
Merged
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
wp dist-archiveが参照する.distignoreは.gitignoreと同じく、行頭スラッシュなしのパターンは全階層に再帰マッチします。そのためsrcと書くとvendor/**/srcまでマッチしてしまいます。hameslack は vendor をリポジトリに同梱しており、vendor 配下には
srcディレクトリが 52 個存在します。素のsrc行のままリリースすると、これら vendor 配下のsrcがすべて配布物から除外され、Composer オートロードが壊れてインストール直後に fatal error になります。ルート直下のみを除外したいディレクトリには
/srcのように行頭アンカーが必要です。変更内容
.distignoreのsrcを/srcに変更(ルート直下のsrcのみ除外し、vendor/**/srcは保持)これにより、リリースアーカイブに vendor 配下のオートロード対象がすべて含まれ、fatal error を回避できます。