π‘οΈ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore#194
π‘οΈ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore#194hackerxj2010 wants to merge 1 commit into
Conversation
This change secures the `LocalJsonStore` against path traversal vulnerabilities by: 1. Filtering out `.` and `..` segments from provided keys. 2. Using `path.relative` to verify that the final resolved path remains within the store's base directory. A new security test suite has been added to verify these protections and prevent regressions. π¨ Severity: CRITICAL π‘ Vulnerability: Path traversal in LocalJsonStore π― Impact: Unauthorized file read/write outside the designated storage directory. π§ Fix: Key sanitization and boundary validation using `path.relative`. β Verification: Ran `packages/documents/src/security.test.ts` and the full `pnpm test` suite. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore
This change secures the
LocalJsonStoreagainst path traversal vulnerabilities by:.and..segments from provided keys.path.relativeto verify that the final resolved path remains within the store's base directory.A new security test suite has been added to verify these protections and prevent regressions.
π¨ Severity: CRITICAL
π‘ Vulnerability: Path traversal in LocalJsonStore
π― Impact: Unauthorized file read/write outside the designated storage directory.
π§ Fix: Key sanitization and boundary validation using
path.relative.β Verification: Ran
packages/documents/src/security.test.tsand the fullpnpm testsuite.PR created automatically by Jules for task 7769651726634502811 started by @hackerxj2010