Skip to content

fix upload shares with password#2589

Merged
gtsteffaniak merged 1 commit into
dev/v1.5.1from
fix/upload-share-with-password
Jul 2, 2026
Merged

fix upload shares with password#2589
gtsteffaniak merged 1 commit into
dev/v1.5.1from
fix/upload-share-with-password

Conversation

@Kurami32

@Kurami32 Kurami32 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Fixes #2465

Summary by CodeRabbit

  • Bug Fixes
    • The embedded upload panel now appears based on the correct share password validation state, improving reliability when viewing shared file listings.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 98e4b5d7-7309-4e70-b25e-dc4643478a22

📥 Commits

Reviewing files that changed from the base of the PR and between 5f85a89 and aea6d38.

📒 Files selected for processing (1)
  • frontend/src/views/files/ListingView.vue

📝 Walkthrough

Walkthrough

Modified the conditional expression controlling visibility of the upload-share-embed UI in ListingView.vue, switching the passwordValid check from state.share?.passwordValid to shareInfo.passwordValid.

Changes

Upload Embed Visibility Fix

Layer / File(s) Summary
Password validity check for upload embed
frontend/src/views/files/ListingView.vue
Changed the v-else-if condition to use shareInfo.passwordValid instead of state.share?.passwordValid for showing the upload-share-embed UI.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A hop, a tweak, a single line,
shareInfo now decides just fine,
the upload box no longer hides,
passwords checked, the form abides,
🐇 one small fix, uploads arrive!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing password-protected upload shares.
Linked Issues check ✅ Passed The change aligns with #2465 by correcting the password-valid check that controls whether the upload UI renders.
Out of Scope Changes check ✅ Passed The PR is narrowly scoped to a single condition change directly related to the linked upload-share bug.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/upload-share-with-password

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gtsteffaniak gtsteffaniak merged commit e59a61f into dev/v1.5.1 Jul 2, 2026
22 checks passed
@gtsteffaniak gtsteffaniak deleted the fix/upload-share-with-password branch July 2, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants