[Draft] Fix cleanup of GRPCRoute resources in namespaces without psm-csm suffix#264
Draft
sreenithi wants to merge 1 commit into
Draft
[Draft] Fix cleanup of GRPCRoute resources in namespaces without psm-csm suffix#264sreenithi wants to merge 1 commit into
sreenithi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DO-NOT-MERGE] Yet to be tested.
Cleanup job was recently failing for some namespaces like:
When inspecting these name spaces manually, found that these have a pending backend service and a gRPC route attached to it
We ideally create a gRPC route only in gamma tests that should have a psm-csm suffix in the namespace. So Gamma servers cleanups that are triggered for
psm-csmprefixed namespaces handle the grpc-route deletion correctly.But looks like these non-Gamma namespaces also have a gRPC route attached with them at times and don't clean them correctly.
So, this PR just checks if such a route resource exists and delegates the cleanup to the Gamma servers cleanups instead.
Note:
However, the above problematic namespaces have been manually cleaned up already, so there is currently no way to test this change. Will open this up for review once tested.