Repository navigation
Conversation
The fallback read the .value of a c_char array, which follows C string semantics and truncated OPAQUE and STRUCT values at the first NUL byte. CtlType.data now holds the plain buffer bytes and only STRING keeps the NUL termination semantics. Fixes #20.
The second SECURE assignment carried the value of CTLMASK_SECURE and overwrote CTLFLAG_SECURE. Add NEEDGIANT, SHIFT_SECURE and SECURE1-3 from current sys/sys/sysctl.h.
PEP 621 metadata with an SPDX license expression (PEP 639) replaces the invalid BSD license classifier. Python 3.10 is the minimum supported version. The test extra replaces the deprecated pytest-runner integration.
pyproject.toml carries all metadata; the build works without the legacy files since setuptools 64.
fmt is a str, query_size returns an int, query_next returns a list, and ctl_type identification passes classes, not instances. The _fmt class attribute was assigned instead of annotated. Resolving name or OID checks the private attributes, so a Sysctl without both no longer recurses infinitely before failing.
ruff replaces the flake8 and bandit setup that the README described but the repository never contained; the S rules cover the bandit checks. The py.typed marker makes the inline annotations visible to type checkers (PEP 561). tests/conftest.py only imported the benchmark plugin, which pytest already loads by itself.
mypy runs once per supported Python version.
The releases section linked the PyPI project of libioc, and the development section referenced a Makefile that never existed in this repository. CODEOWNERS assigned a VERSION file that does not exist.
The CHANGELOG section that described Travis and Cirrus CI and a 0.11.0 bump never matched reality; PR #5 was not merged and those services were never set up.
test_sysctl_refresh from #19 asserts that the free page count changes on every loop iteration while allocating memory, which is flaky by design. Spawning a child process changes kern.lastpid deterministically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.