Conversation
The fallback read the .value of a c_char array, which follows C string semantics and truncated OPAQUE and STRUCT values at the first NUL byte. CtlType.data now holds the plain buffer bytes and only STRING keeps the NUL termination semantics. Fixes #20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading an OPAQUE or STRUCT sysctl returned a value truncated at the first NUL byte, reported upstream as #20.
The base
CtlType.valuefallback read the.valueof actypes.c_chararray, which follows C string semantics.Changes:
query_value()hands the raw buffer bytes to the value class, soCtlType.datais plainbytes.CtlType.valuereturns the complete bytes when no unpack format is defined; onlySTRINGkeeps NUL termination semantics.kern.boottime,kern.clockrateandvm.loadavgagainst/sbin/sysctl -b.