Skip to content

Handle Int32 matrix dimensions in ConsecutiveParamSparseMatrixCSC (Julia 1.12 x86 CI failure) - #69

Draft
nichomueller with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-failing-github-actions-job-again
Draft

Handle Int32 matrix dimensions in ConsecutiveParamSparseMatrixCSC (Julia 1.12 x86 CI failure)#69
nichomueller with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-failing-github-actions-job-again

Conversation

Copilot AI commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

The Tests 1.12 - ubuntu-latest - x86 - push workflow failed in steady diagnostics due to a constructor dispatch mismatch: ConsecutiveParamSparseMatrixCSC was called with Int32 dimensions, but only Int64-typed dimension constructor dispatch was available.

  • Root cause

    • create_from_nz can produce Int32 nrows/ncols on this CI target.
    • ConsecutiveParamSparseMatrixCSC required m::Int64, n::Int64, causing a MethodError in the diagnostics path.
  • Code change

    • Added a narrow outer constructor in ParamSparseMatrices.jl:
      • accepts m::Integer, n::Integer
      • forwards as Int(m), Int(n) to existing constructor
    • Keeps existing storage/index typing (Ti) and data typing (A<:AbstractMatrix{Tv}) unchanged.
  • Regression coverage

    • Added a focused test in test/FEM/param_data_structures.jl to construct ConsecutiveParamSparseMatrixCSC with Int32 dimensions and verify structural invariants (innersize, nnz, type parameters).
function ConsecutiveParamSparseMatrixCSC(
  m::Integer, n::Integer,
  colptr::Vector{Ti}, rowval::Vector{Ti}, data::A
) where {Tv,Ti<:Integer,A<:AbstractMatrix{Tv}}
  ConsecutiveParamSparseMatrixCSC(Int(m), Int(n), colptr, rowval, data)
end

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Tests 1.12 Handle Int32 matrix dimensions in ConsecutiveParamSparseMatrixCSC (Julia 1.12 x86 CI failure) Jul 25, 2026
Copilot AI requested a review from nichomueller July 25, 2026 14:43
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.26%. Comparing base (b017434) to head (33e84ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   46.26%   46.26%           
=======================================
  Files         126      126           
  Lines       19280    19282    +2     
=======================================
+ Hits         8919     8921    +2     
  Misses      10361    10361           
Flag Coverage Δ
tests 46.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants