Handle Int32 matrix dimensions in ConsecutiveParamSparseMatrixCSC (Julia 1.12 x86 CI failure) - #69
Draft
nichomueller with Copilot wants to merge 2 commits into
Draft
Handle Int32 matrix dimensions in ConsecutiveParamSparseMatrixCSC (Julia 1.12 x86 CI failure)#69nichomueller with Copilot wants to merge 2 commits into
ConsecutiveParamSparseMatrixCSC (Julia 1.12 x86 CI failure)#69nichomueller with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Tests 1.12
Handle Int32 matrix dimensions in Jul 25, 2026
ConsecutiveParamSparseMatrixCSC (Julia 1.12 x86 CI failure)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 46.26% 46.26%
=======================================
Files 126 126
Lines 19280 19282 +2
=======================================
+ Hits 8919 8921 +2
Misses 10361 10361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Tests 1.12 - ubuntu-latest - x86 - pushworkflow failed in steady diagnostics due to a constructor dispatch mismatch:ConsecutiveParamSparseMatrixCSCwas called withInt32dimensions, but onlyInt64-typed dimension constructor dispatch was available.Root cause
create_from_nzcan produceInt32nrows/ncolson this CI target.ConsecutiveParamSparseMatrixCSCrequiredm::Int64, n::Int64, causing aMethodErrorin the diagnostics path.Code change
ParamSparseMatrices.jl:m::Integer, n::IntegerInt(m), Int(n)to existing constructorTi) and data typing (A<:AbstractMatrix{Tv}) unchanged.Regression coverage
test/FEM/param_data_structures.jlto constructConsecutiveParamSparseMatrixCSCwithInt32dimensions and verify structural invariants (innersize,nnz, type parameters).