Change: allow editing a scan config in use, and do not deselect every NVT when the families are not loaded - #5544
Open
TheBeast85 wants to merge 2 commits into
Open
Conversation
The edit dialog fetches the config and the list of NVT families in parallel and builds trend and select from both, once, as soon as the config has arrived. When the config arrived first the family list was still undefined, so the selection came out empty and stayed that way. Saving then sent a family selection covering no family, which gsad turns into a family_selection element without a single family, and gvmd reads that as "deselect everything": every fully selected family of the config was cleared. Wait for both requests before building the selection, and leave the family part out of the request while the selection is unknown, so a save can no longer send an empty one.
greenbonebot
enabled auto-merge (rebase)
August 19, 2026 07:27
TheBeast85
changed the title
The edit dialog replaced families, scanner preferences and NVT preferences with a notice as soon as a task referred to the config, and the component cut the request down to name, comment and id. The same applied to a policy that an audit refers to. gvmd no longer refuses these changes, so the dialog shows the full form and sends everything the user edited.
Contributor
|
Please split such things into two different PRs. As I mentioned in your other PRs the "in use" changes have no chance of being applied at the moment. This is nothing we are going to change anytime soon. It has a serious use case. If you want the fix for the trend/select stuff merged feel free to adapt this PR and force push or to close it and create a new PR. |
auto-merge was automatically disabled
August 19, 2026 07:48
Head branch was pushed to by a user without write access
TheBeast85
force-pushed
the
change/edit-scan-config-in-use
branch
from
August 19, 2026 07:48
cd237a1 to
db6fa1b
Compare
greenbonebot
enabled auto-merge (rebase)
August 19, 2026 07:48
Contributor
|
@TheBeast85 The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
trend/selectonly once the config and the family list have arrived, and leave the family part out of the request while the selection is unknownWhy
The edit dialog fetches the config and the list of NVT families in parallel and builds
trend/selectonce, as soon as the config has arrived. When the config arrives first,familiesis still undefined,createTrendAndSelectreturns empty objects, and the guard keeps them that way. Saving then sends only the baretrendparameter, gsad turns that into afamily_selectionelement without a singlefamily, and gvmd reads that as "no family selected" and clears every fully selected family of the config. GEA-1698 fixed the case where the parent dialog held a stale value for one family; this is the case where it holds no family at all.The in-use notice replaced families, scanner preferences and NVT preferences, and the component cut the request down to name, comment and id. gvmd no longer refuses those changes (greenbone/gvmd#3099), so the dialog can show the full form.
References
GEA-1698, greenbone/gvmd#3099
Checklist