Add: add dark mode theming - #5330
Open
Chri6s wants to merge 2 commits into
Open
Conversation
greenbonebot
enabled auto-merge (rebase)
June 4, 2026 17:31
auto-merge was automatically disabled
June 5, 2026 11:59
Head branch was pushed to by a user without write access
greenbonebot
enabled auto-merge (rebase)
June 5, 2026 12:00
auto-merge was automatically disabled
June 7, 2026 22:09
Head branch was pushed to by a user without write access
greenbonebot
enabled auto-merge (rebase)
June 7, 2026 22:09
auto-merge was automatically disabled
June 7, 2026 22:10
Head branch was pushed to by a user without write access
greenbonebot
enabled auto-merge (rebase)
June 7, 2026 22:11
auto-merge was automatically disabled
June 10, 2026 11:15
Head branch was pushed to by a user without write access
greenbonebot
enabled auto-merge (rebase)
June 10, 2026 11:15
auto-merge was automatically disabled
June 10, 2026 14:54
Head branch was pushed to by a user without write access
greenbonebot
enabled auto-merge (rebase)
June 10, 2026 14:54
auto-merge was automatically disabled
June 10, 2026 18:58
Head branch was pushed to by a user without write access
greenbonebot
enabled auto-merge (rebase)
June 10, 2026 18:58
Chri6s
marked this pull request as draft
June 15, 2026 13:18
auto-merge was automatically disabled
June 15, 2026 13:18
Pull request was converted to draft
- Enable built-in theme switch component in AppHeader and default to system preferences. - Add safety logic to d3-color operations in chart components to prevent runtime crashes with CSS variables.
Fixed coloring of widget close button, coloring of chart slice labels, line charts and matched tests accordingly.
Chri6s
marked this pull request as ready for review
June 15, 2026 13:19
Author
|
@bjoernricks Can I request a review for this PR as there are new UI changes which could cause wrong coloring in specific views/icons etc.? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ThemeSwitchinside the header.d3-colorchart computations to prevent crashes.Why
References
Checklist