Fix ad volume slider mute state - #1217
Merged
Kiro705 merged 1 commit intoJul 22, 2026
Merged
Conversation
Kiro705
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ad volume slider mute state when dragging the slider to zero.
AdUi.prototype.changeVolumecalculates the current slider percentage in the localpercentvariable, but the mute state check was usingthis.percent, which is not set.This caused the muted UI state to be based on an undefined property instead of the current slider value.This appears to be a typo:
changeVolumecomputes the current slider percentage in the localpercentvariable, but the mute state check readsthis.percentinstead.