Repository navigation
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply
MS_RDONLYtogether with the other per-mount restrictions when the new mount API clones a recursive bind subtree.open_tree(..., AT_RECURSIVE)clones nested submounts, butdoBindMountAt()previously strippedMS_RDONLYbefore the recursivemount_setattr()call. The later bind remount only affects the top mount. With a writable jail root, nested submounts could therefore remain writable.This passes the full requested flag set to
applyMountFlags(), soMOUNT_ATTR_RDONLYis applied recursively beforemove_mount().Fixes #369.
Validation
open_tree()clone with a nested tmpfs:MOUNT_ATTR_RDONLY: top bind read-only, nested tmpfs read-onlygit diff --checkpasses.This intentionally does not change the separate mount-attribute failure handling tracked in #312.