Repository navigation
ci: pin GitHub Actions runner images instead of relying on *-latest - #1576
Merged
Merged
Conversation
Replace floating *-latest runner labels across .github/workflows/ and dist-workspace.toml with explicit OS image versions (ubuntu-26.04, macos-26, windows-2025, and ubuntu-24.04 where glibc 2.39 compatibility or legacy Python toolchains require it) so runner upgrades happen deliberately via PRs. Fixes #1573
Coverage Report for CI Build 40825876822Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 96.845%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Collaborator
Author
|
@ia0 FYI ubuntu-latest is migrating from 24.04 to 26.06 and broke some stuff. now following best practices and pinning the runners to specific versions to avoid this in the future. the auto generated cli-release.yaml is drifting (and still has the warnings from the CI checks), but I guess it is what it is for now... |
Member
|
Yes, cli-release is in a bad shape and there has been no activity from the maintainers on axodotdev/cargo-dist#2320 (but it got a recent activity from users experiencing the same issue). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace floating
*-latestGitHub Actions runner labels across.github/workflows/anddist-workspace.tomlwith explicit OS image versions so runner image upgrades happen deliberately via PRs instead of unannounced upstream rollovers:ubuntu-latest->ubuntu-26.04,macos-latest->macos-26, andwindows-latest->windows-2025(including replacing${{ matrix.os }}-latestinrust-test.yml'srunjob with an explicit[ubuntu-26.04, macos-26, windows-2025]matrix).dist-workspace.toml,cli-release.yml,rust-test.ymltract-parity): Pin Linux x86_64 and globalcargo-distjobs toubuntu-24.04(preserving glibc 2.39 compatibility alongsideubuntu-24.04-armand matchingcargo-distv0.31.0'sKNOWN_GITHUB_RUNNERS), macOS arm64 tomacos-26, and Windows x64 towindows-2025.python-build-test-and-release-package.yml): Keepubuntu-24.04ontest-wheels-legacy-python(for prebuilt Python 3.8/3.9 binaries inactions/setup-python) and keep existingmacos-14pins untouched.Testing: Verified with
uv run scripts/check_gh_actions.py,just python check-source,just python check-docs,just python test, and PR CI workflows.Fixes #1573